Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow config mismatches #24

Merged
merged 4 commits into from
Dec 1, 2024
Merged

Allow config mismatches #24

merged 4 commits into from
Dec 1, 2024

Conversation

SagiPolaczek
Copy link
Contributor

@SagiPolaczek SagiPolaczek commented Nov 27, 2024 •
edited
Loading

Motivation

  • Loading an extended trained model with unsupported config arguments.

Example of use:

innersource_model.save_pretrained(save_directory=tmp_dir, mode="huggingface")
opensource_model = Mammal.from_pretrained(tmp_dir, allow_config_mismatch=True)

@SagiPolaczek SagiPolaczek marked this pull request as ready for review November 27, 2024 13:46
mosheraboh
mosheraboh reviewed Dec 1, 2024
View reviewed changes
mammal/model.py

if len(mismatch_keys) > 0:
print(
f"Warning, mismatch detected! Make sure you know what you are doing... {mismatch_keys=}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣

mosheraboh
mosheraboh approved these changes Dec 1, 2024
View reviewed changes
Copy link
Contributor

@mosheraboh mosheraboh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SagiPolaczek SagiPolaczek merged commit e2f614c into main Dec 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosheraboh mosheraboh mosheraboh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SagiPolaczek @mosheraboh